Implement '/lgtm' ChatOps Workflow. by revit13 · Pull Request #612 · llm-d/llm-d-inference-scheduler

revit13 · 2026-02-12T11:21:56Z

This pr replaces the Prow-based /lgtm implementation (#580).

The solution decouples the logic into the following workflows:

Command Handler (lgtm-command): Validates authorized users and triggers auto-merge.
Gatekeeper (lgtm-gatekeeper): A Required Status Check that blocks merges if lgtm or approve is missing or hold label exist.
Reset Mechanism (lgtm-reset): Automatically revokes approval (removes lgtm) when new commits are pushed. (triggers Gatekeeper)
below is a diagram of the execution flow.

Note:

auto-merge should be enabled for all branches.
All other ChatOps commands remain handled by jpmcb/prow-github-actions.
The Gatekeeper workflow must be manually configured as a Required Status Check for all branches (can be done via the GitHub UI). This step is critical to ensure auto-merge waits for the safety checks to pass.
A GitHub App is used with tibdex/github-app-token@v1 to generate tokens that bypass the GITHUB_TOKEN restriction, ensuring that bot-triggered events (like labeling) successfully spawn subsequent workflow runs.

Tested on my local fork.

Signed-off-by: Revital Sur <eres@il.ibm.com>

…tekeeper' workflow. Signed-off-by: Revital Sur <eres@il.ibm.com>

Signed-off-by: Revital Sur <eres@il.ibm.com>

elevran · 2026-02-12T16:05:10Z

.github/workflows/lgtm-command.yml

typo in file name, missing n

Thanks will fix it.

elevran · 2026-02-12T16:06:50Z

.github/workflows/dispatch-on-lgtm.yml

@@ -0,0 +1,18 @@
+name: ChatOps Dispatcher


due to my lack of knowledge, what does this action do? Is only used to dispatch other jobs when a comment is made?

Yes It is a "traffic controller" action that robustly parses slash commands (like /lgtm) from comments, validates user permissions, and dispatches events to trigger specific workflows.

elevran · 2026-02-12T16:07:25Z

.github/workflows/dispatch-on-lgtm.yml

@@ -0,0 +1,18 @@
+name: ChatOps Dispatcher
+on:
+  issue_comment:


Q: shuoldn't this be done on PR comments? (assuming there is such a trigger)

No, apparently in GitHub's internal architecture, every Pull Request is an Issue. It has issue-type: pull-request defined later in the yml...

elevran · 2026-02-12T16:09:25Z

.github/workflows/lgtm-command.yml

+#
+# Flow:
+# 1. User comments /lgtm on PR
+# 2. chatops-dispatcher catches it and dispatches here


how does the dispatcher know which job/action to invoke?
I did not see a reference to lgtm-command in that file.

It is an "invisible handshake" done through Events, not file references. When /lgtm is typed, the slash-command-dispatch action fires a Repository Dispatch event. By default, it constructs the event type by adding -command to the slash command.

The Signal: When the dispatcher validates the /lgtm comment, it broadcasts a repository_dispatch event with the custom type lgtm-command.

The Listener: The lgtm-command.yml workflow is explicitly configured to listen for this signal via types: [lgtm-command].

elevran · 2026-02-12T16:10:30Z

.github/workflows/dispatch-on-lgtm.yml

not a fan of calling it "chatops" in file or action name. Please use a more specific name (e.g. dispatch-on-lgtm)

Sure Thanks

elevran · 2026-02-12T16:18:36Z

.github/workflows/lgtm-commad.yml

+      - name: Apply Label & Merge
+        if: steps.check.outputs.authorized == 'true'
+        env:
+          GH_TOKEN: ${{ secrets.BOT_TOKEN }}


Q: how do we issue and maintain a bot token? who owns it (e.g., user associated, expiration time, ...)

I need to investigate how to properly configure a Personal Access Token (PAT) for this repository.

I've updated the workflows to use a GitHub App via tibdex/github-app-token@v1, which generates short-lived access tokens automatically. This eliminates the need for a dedicated, long-lived Personal Access Token (PAT) and ensures that bot-triggered events successfully spawn subsequent workflow runs.

elevran · 2026-02-12T16:19:38Z

.github/workflows/lgtm-commad.yml

+            exit 1
+          fi
+
+          echo "Waiting 5 minutes before setting auto-merge..."


is the sleep required?
having a job wait for 5m slows down the loop. Is there a way to structure the events so the wait is not needed?

No, its not needed and can be removed. I wanted to give the pr writer or other approver an opportunity to take a final look at the checks or the code before the merge sequence officially started when the testing is finishes quickly. I will remove it.

elevran · 2026-02-12T16:21:47Z

.github/workflows/lgtm-gatekeeper.yml

@@ -0,0 +1,42 @@
+# ============================================================================
+# LGTM Gatekeeper - Required Status Check


Q: there seems to be quite a bit of overlap between this file and the previous. Can you explain how they differ and what purpuse they serve.

I generated a diagram hope it helps to clarify.

elevran · 2026-02-12T16:22:05Z

.github/workflows/lgtm-gatekeeper.yml

+            exit 1
+          fi
+
+          echo "✅ PASSED: LGTM present and no blockers."


nit: missing newline at end of file

Thanks will fix that.

elevran · 2026-02-12T16:22:27Z

.github/workflows/lgtm-reset.yml

+          gh pr merge --disable-auto $PR_NUMBER --repo "$REPO" || true
+
+          # 3. Notify user
+          gh issue comment $PR_NUMBER --repo "$REPO" --body "🔄 **Reset**: New commits pushed. LGTM removed."


nit: newline at end of file

Thanks will fix that.

vMaroon · 2026-02-13T17:04:29Z

Hi @revit13, @elevran, how is this positioned with Andy's

🌱 Standardize governance workflows, pre-commit, and tooling #616

elevran · 2026-02-13T18:13:03Z

It is complementary.
The prow auto merge was not working reliably and this attempts to fix it. A reliably working version would be moved to the shared infra.

Signed-off-by: Revital Sur <eres@il.ibm.com>

shmuelk · 2026-02-22T10:39:04Z

DEVELOPMENT.md

+
+## PR Approval Process
+
+The project uses a Prow-inspired ChatOps system to manage PR approvals via comment commands.


ChatOps was removed from PR ?

ChatOps hasn't been removed, but the /lgtm command was separated from the standard Prow bot into a dedicated, custom workflow.

shmuelk · 2026-02-22T10:39:47Z

DEVELOPMENT.md

+- ✅ **Both `lgtm` and `approve` labels** - Required for merge approval
+- ✅ **No blocking labels** - The `hold` label must not be present
+- ✅ **All required status checks passing** - CI/CD checks must succeed
+


Please Signed verified commits

Updated Developer.md: Added documentation noting that signed commits can be enforced as a pre-merge check via branch rulesets

Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 · 2026-02-27T04:58:29Z

Thanks for the feedback on this! I'm going to close this out for now so I can do some more thorough testing on my end before moving forward.

Implement "LGTM" ChatOps Workflow.

6692afe

Signed-off-by: Revital Sur <eres@il.ibm.com>

github-project-automation bot added this to llm-d-inference-scheduler Feb 12, 2026

revit13 marked this pull request as draft February 12, 2026 11:22

github-actions bot requested review from nirrozenbaum and shmuelk February 12, 2026 11:22

revit13 added 2 commits February 12, 2026 15:33

Use a PAT (BOT_TOKEN) instead of GITHUB_TOKEN to trigger the 'lgtm-ga…

71a218e

…tekeeper' workflow. Signed-off-by: Revital Sur <eres@il.ibm.com>

Use secrets.BOT_TOKEN in lgtm-reset.yml.

4203f6c

Signed-off-by: Revital Sur <eres@il.ibm.com>

elevran reviewed Feb 12, 2026

View reviewed changes

revit13 added 2 commits February 15, 2026 08:18

Address review comments.

077f8de

Signed-off-by: Revital Sur <eres@il.ibm.com>

Handle approvals.

85a7d53

Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 marked this pull request as ready for review February 15, 2026 08:21

revit13 added 3 commits February 15, 2026 10:30

Minor fix to comment.

bf39544

Signed-off-by: Revital Sur <eres@il.ibm.com>

Merge branch 'main' into lgtm1

bb36230

Update lgtm autherzation.

60cb0ff

Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 changed the title ~~Implement "LGTM" ChatOps Workflow.~~ Implement '/lgtm' ChatOps Workflow. Feb 16, 2026

revit13 mentioned this pull request Feb 16, 2026

🌱 Standardize governance workflows, pre-commit, and tooling #616

Closed

2 tasks

shmuelk requested changes Feb 22, 2026

View reviewed changes

github-project-automation bot moved this to In review in llm-d-inference-scheduler Feb 22, 2026

revit13 added 2 commits February 24, 2026 10:47

Address review comments.

2f3dbb7

Signed-off-by: Revital Sur <eres@il.ibm.com>

Update lgtm-gatekeeper to handle approval.

a7fb2b5

Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 marked this pull request as draft February 27, 2026 04:55

revit13 closed this Feb 27, 2026

github-project-automation bot moved this from In review to Done in llm-d-inference-scheduler Feb 27, 2026

		@@ -0,0 +1,42 @@
		# ============================================================================
		# LGTM Gatekeeper - Required Status Check


		## PR Approval Process

		The project uses a Prow-inspired ChatOps system to manage PR approvals via comment commands.

Conversation

revit13 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revit13 Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revit13 Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vMaroon commented Feb 13, 2026

Uh oh!

elevran commented Feb 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revit13 Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revit13 commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

revit13 commented Feb 12, 2026 •

edited

Loading

revit13 Feb 13, 2026 •

edited

Loading

revit13 Feb 13, 2026 •

edited

Loading

revit13 Feb 27, 2026 •

edited

Loading